[Mlir-commits] [mlir] da492d4 - [mlir][vector] Fix return of `DropUnitDimsFromTransposeOp` pattern (#102478)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Thu Aug 8 08:31:14 PDT 2024


Author: Benjamin Maxwell
Date: 2024-08-08T16:31:11+01:00
New Revision: da492d438790cc7c51f962071a887af7d20be30d

URL: https://github.com/llvm/llvm-project/commit/da492d438790cc7c51f962071a887af7d20be30d
DIFF: https://github.com/llvm/llvm-project/commit/da492d438790cc7c51f962071a887af7d20be30d.diff

LOG: [mlir][vector] Fix return of `DropUnitDimsFromTransposeOp` pattern (#102478)

This accidentally returned `failure()` (rather than `success()`) when it
applied.

Added: 
    

Modified: 
    mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
index 55c1c6bad9f2a..bc0c96b32a80f 100644
--- a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
+++ b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
@@ -1782,7 +1782,7 @@ struct DropUnitDimsFromTransposeOp final
     rewriter.replaceOpWithNewOp<vector::ShapeCastOp>(
         op, op.getResultVectorType(), tranposeWithoutUnitDims);
 
-    return failure();
+    return success();
   }
 };
 


        


More information about the Mlir-commits mailing list