[Mlir-commits] [mlir] [mlir][vector] Fix return of `DropUnitDimsFromTransposeOp` pattern (PR #102478)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Thu Aug 8 07:27:49 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-vector

Author: Benjamin Maxwell (MacDue)

<details>
<summary>Changes</summary>

This accidentally returned `failure()` (rather than `success()`) when it applied.

---
Full diff: https://github.com/llvm/llvm-project/pull/102478.diff


1 Files Affected:

- (modified) mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp (+1-1) 


``````````diff
diff --git a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
index 55c1c6bad9f2a4..bc0c96b32a80f5 100644
--- a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
+++ b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
@@ -1782,7 +1782,7 @@ struct DropUnitDimsFromTransposeOp final
     rewriter.replaceOpWithNewOp<vector::ShapeCastOp>(
         op, op.getResultVectorType(), tranposeWithoutUnitDims);
 
-    return failure();
+    return success();
   }
 };
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/102478


More information about the Mlir-commits mailing list