[Mlir-commits] [mlir] [mlir][vector] Fix return of `DropUnitDimsFromTransposeOp` pattern (PR #102478)

Benjamin Maxwell llvmlistbot at llvm.org
Thu Aug 8 07:27:18 PDT 2024


https://github.com/MacDue created https://github.com/llvm/llvm-project/pull/102478

This accidentally returned `failure()` (rather than `success()`) when it applied.

>From b737cd6a0f48a5eefd5bb181fd3dd18bdf2bb681 Mon Sep 17 00:00:00 2001
From: Benjamin Maxwell <benjamin.maxwell at arm.com>
Date: Thu, 8 Aug 2024 14:20:17 +0000
Subject: [PATCH] [mlir][vector] Fix return of `DropUnitDimsFromTransposeOp`
 pattern

This accidentally returned `failure()` (rather than `success()`) when it
applied.
---
 mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
index 55c1c6bad9f2a4..bc0c96b32a80f5 100644
--- a/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
+++ b/mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
@@ -1782,7 +1782,7 @@ struct DropUnitDimsFromTransposeOp final
     rewriter.replaceOpWithNewOp<vector::ShapeCastOp>(
         op, op.getResultVectorType(), tranposeWithoutUnitDims);
 
-    return failure();
+    return success();
   }
 };
 



More information about the Mlir-commits mailing list