[Mlir-commits] [mlir] [mlir][linalg] Exclude non-convolutional ops from isaConvolutionOpInterface (PR #102087)

[llvmlistbot at llvm.org]

yifeizh2 wrote:

> > Some testing would be nice, but that would have to be a unit test and there's just none for Linalg atm :( I'm leaving that as a nice-to-have.
> 
> I was trying to think about what kind of test could be added, but this is pretty much just exposing an option that was already there. If we wanted to make it essentially NFC we could change the default back. We could also add a transform dialect op for `isaConvolutionOpInterface`, but I have the same thinking as you about nice-to-have.

I had planned to add some unit tests for this logic change, but I failed to find existing unit tests for its counterparts (e.g. `isaContractionOpInterface`) as reference.

As for testing with transform dialect op, currently we have `transform.match.structured.classify_convolution_dims`, would you think it is better to add a new op such as `transform.match.structured.convolution_op_interface` which invokes `isaConvolutionOpInterface` and add corresponding unit tests

https://github.com/llvm/llvm-project/pull/102087