[Mlir-commits] [mlir] [mlir][ODS] Verify type constraints in Types and Attributes (PR #102326)

Jacques Pienaar llvmlistbot at llvm.org
Wed Aug 7 14:45:03 PDT 2024


================
@@ -153,6 +153,9 @@ class TypeConstraint<Pred predicate, string summary = "",
     Constraint<predicate, summary> {
   // The name of the C++ Type class if known, or Type if not.
   string cppClassName = cppClassNameParam;
+  // TODO: This field is sometimes called `cppClassName` and sometimes
----------------
jpienaar wrote:

This one has cppClassName above, is this effectively duplicating it to enable reuse? (Alternative would be having ODS check for either as staging mechanism + no need to introduce here, then full rename can be done)

https://github.com/llvm/llvm-project/pull/102326


More information about the Mlir-commits mailing list