[Mlir-commits] [mlir] [mlir][vector] Add mask elimination transform (PR #99314)
Andrzej WarzyĆski
llvmlistbot at llvm.org
Wed Aug 7 08:15:21 PDT 2024
https://github.com/banach-space approved this pull request.
Thanks for all the refactor and code re-use. The split between `CreateMaskFolder` and `eliminateVectorMasks` is much clearer now.
It would be good to briefly contrast what you are adding here with the current folder in the summary. That's where most people will be looking for documentation.
I believe that this addresses all of Diego's concerns. I know that he's OOO over the coming weeks and it would be really good to land this sooner rather than later. I will accept this (% my comments re documentation) and let's land this. If there's more suggestions from Diego post-commit, we can address those in follow-up PRs.
https://github.com/llvm/llvm-project/pull/99314
More information about the Mlir-commits
mailing list