[Mlir-commits] [mlir] [MLIR][GPU-LLVM] Convert `gpu.func` to `llvm.func` (PR #101664)

Victor Perez llvmlistbot at llvm.org
Wed Aug 7 00:49:04 PDT 2024


================
@@ -57,10 +80,18 @@ struct GPUFuncOpLowering : ConvertOpToLLVMPattern<gpu::GPUFuncOp> {
   unsigned workgroupAddrSpace;
 
   /// The attribute name to use instead of `gpu.kernel`.
-  StringAttr kernelAttributeName;
-
+  std::optional<StringAttr> kernelAttributeName;
----------------
victor-eds wrote:

You're right. I was following what was already there, but I think it's better using attribute nullability.

https://github.com/llvm/llvm-project/pull/101664


More information about the Mlir-commits mailing list