[Mlir-commits] [mlir] [mlir][linalg] Implement TilingInterface for winograd operators (PR #96184)

[llvmlistbot at llvm.org]

https://github.com/Max191 requested changes to this pull request.

This is looking pretty good so far, just a couple of comments.

1. Try to avoid using "magic numbers", and add `extraClassDeclaration` when possible to get indices of specific dimensions.
2. Each of the 3 winograd ops have 2 dimensions that should not be tiled, but it is actually still good to include the dims in the iteration domain. This is because it makes tiling + fusion easier. See my comment below for more details.

https://github.com/llvm/llvm-project/pull/96184