[Mlir-commits] [mlir] mlir: add an operation to EmitC for function template instantiation (PR #100895)

[Gil Rapaport]

aniragil wrote:

> Sorry for not following up earlier. Isn't `call_lib` essentially the same as `call_opaque` with the lack of support for template arguments? In that case I think I would choose a different name instead of `call_lib` or even just keep the current name `call_opaque`. The disadvantage is that it is not as clear that the behavior will change as it would be with having a differently named op, but I favor this over introducing ops with not that clear names.

Then how about we extend `emitc.call` to accept string attrs, callable values and function pointers as callees in addition to symbols? Is that enough to drop `emitc.call_opaque`?

https://github.com/llvm/llvm-project/pull/100895