[Mlir-commits] [mlir] [mlir][OpenMP] Implement the ConvertToLLVMPatternInterface (PR #101997)

[Fabian Mora]

fabianmcg wrote:

> The only question is whether there will be a confusion here because other conversions (of arith, memref etc) fully convert to LLVM dialect whereas OpenMP only converts the types and retains the OpenMP operations.

Not likely, this interface only picks up upstream OpenMP to LLVM patterns (the exact same patterns as `ConvertOpenMPToLLVM`), hence users shouldn't expect different behavior.

I'll also say that this is a pretty overridable change. For example, if one day a downstream user creates explicit lowerings to LLVM, they can implement the `ToLLVM` interface and substitute the registration call with theirs and the `convert-to-llvm` pass would use the downstream implementation. What I'm trying to say, is that this change is pretty localized to upstream MLIR.

https://github.com/llvm/llvm-project/pull/101997