[Mlir-commits] [mlir] [mlir][linalg] Fix isaConvolutionOpInterface logic (PR #102087)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Mon Aug 5 23:00:49 PDT 2024
yifeizh2 wrote:
> This has bothered me as well, especially because this helper is inconsistent with which named ops carry the convolution interface. I think it would be best to just expose `allowEmptyConvolvedDims` to users and default it to false.
Hi. I updated the logic. Currently the logic for `allowEmptyConvolvedDims` in `isConvolutionInterfaceImpl` is a duplicate of that in `inferConvolutionDimsImpl`, making the code not concise.
https://github.com/llvm/llvm-project/pull/102087
More information about the Mlir-commits
mailing list