[Mlir-commits] [mlir] [mlir][docs] Clarified Dialect creation tutorial + fixed typos (PR #77820)

[Mehdi Amini]

================
@@ -106,6 +106,12 @@ the LINK_COMPONENTS descriptor.  This allows cmake infrastructure to
 generate new library targets with correct linkage, in particular, when
 BUILD_SHARED_LIBS=on or LLVM_LINK_LLVM_DYLIB=on are specified.
 
+Registration of the dialect can be performed globally by editing the
+file include/mlir/InitAllDialects.h.  In this example, we can add
----------------
joker-eph wrote:

> vcix dialect isn't registered in [include/mlir/InitAllDialects.h](https://github.com/llvm/llvm-project/blob/1fec981b67ac57abd4d8defd73beb5a9433c602f/mlir/include/mlir/InitAllDialects.h#L149),

This would be an oversight. 

Actually, it may even be worse than that: dialects are in general testing the syntax of their ops, and that requires dialect registration.

> Dialect registration can be skipped if mlir-opt only generates the dialect, rather than parsing it.

Sure: there is no use-case for this upstream though, I consider it a bug that a dialect wouldn't be part of `InitAllDialects.h` (we don't want this to be a misnomer).

https://github.com/llvm/llvm-project/pull/77820