[Mlir-commits] [mlir] [MLIR][test] Run Integration tests for CPU using qemu-aarch64 (PR #101568)

Cullen Rhodes llvmlistbot at llvm.org
Mon Aug 5 04:26:43 PDT 2024


================
@@ -18,5 +35,12 @@ if config.riscv_vector_emulator_executable:
         emulation_cmd = emulation_cmd + " " + config.riscv_vector_emulator_options
     emulation_cmd = emulation_cmd + " " + lli_cmd + " --march=riscv64 -mattr=+v "
     config.substitutions.append(("%lli", emulation_cmd))
+elif config.arm_emulator_executable:
+    # Run test in qemu emulator.
+    emulation_cmd = config.arm_emulator_executable
+    if config.arm_emulator_options:
+        emulation_cmd = emulation_cmd + " " + config.arm_emulator_options
+    emulation_cmd = emulation_cmd + " " + lli_cmd + " --march=aarch64 -mattr=+neon "
----------------
c-rhodes wrote:

also not clear to me what the rationale here is. I don't believe `arm_emulator_executable` was intended to mean run all the integration tests under emulation, it was intended to support running the integration tests for ISAs like SVE and SME enabled under
- MLIR_RUN_ARM_SVE_TESTS
- MLIR_RUN_ARM_SME_TESTS

where hardware isn't yet widely available. I think we need to mindful here because this will mean these tests are unnecessarily run under emulation on AArch64 hosts and will take longer to run.



https://github.com/llvm/llvm-project/pull/101568


More information about the Mlir-commits mailing list