[Mlir-commits] [mlir] [mlir][docs] Fix return type in Type/Attr printer docs (PR #101958)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Aug 5 03:41:57 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Benjamin Maxwell (MacDue)

<details>
<summary>Changes</summary>

These return `void`, not `Type` or `Attribute` respectively.

---
Full diff: https://github.com/llvm/llvm-project/pull/101958.diff


1 Files Affected:

- (modified) mlir/docs/DefiningDialects/AttributesAndTypes.md (+2-2) 


``````````diff
diff --git a/mlir/docs/DefiningDialects/AttributesAndTypes.md b/mlir/docs/DefiningDialects/AttributesAndTypes.md
index d6941c0b681f8..1430edd2ffb02 100644
--- a/mlir/docs/DefiningDialects/AttributesAndTypes.md
+++ b/mlir/docs/DefiningDialects/AttributesAndTypes.md
@@ -551,13 +551,13 @@ For Types, these methods will have the form:
 
 - `static Type MyType::parse(AsmParser &parser)`
 
-- `Type MyType::print(AsmPrinter &p) const`
+- `void MyType::print(AsmPrinter &p) const`
 
 For Attributes, these methods will have the form:
 
 - `static Attribute MyAttr::parse(AsmParser &parser, Type attrType)`
 
-- `Attribute MyAttr::print(AsmPrinter &p) const`
+- `void MyAttr::print(AsmPrinter &p) const`
 
 #### Using `assemblyFormat`
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/101958


More information about the Mlir-commits mailing list