[Mlir-commits] [mlir] [mlir][vector] Clarify the semantics of BroadcastOp (PR #101928)

Andrzej Warzyński llvmlistbot at llvm.org
Mon Aug 5 03:28:54 PDT 2024


================
@@ -68,9 +68,13 @@ enum class BroadcastableToResult {
   DimensionMismatch = 2,
   SourceTypeNotAVector = 3
 };
+struct VectorDim {
+  int64_t dim;
+  bool scalableFlag;
+};
----------------
banach-space wrote:

This PR is unrelated to that discussion. I'm only adding this here to avoid adding new set of params to `isBroadcastableTo`.

I believe that before we commit to any new wider API, we should discuss the internal representation of `VectorType` and how scalable dimensions are represented. I am working on a proposal, but that's not yet ready to share 😅 I'm hoping to have something in the coming weeks.

https://github.com/llvm/llvm-project/pull/101928


More information about the Mlir-commits mailing list