[Mlir-commits] [mlir] [MLIR][GPU-LLVM] Convert `gpu.func` to `llvm.func` (PR #101664)

Jakub Kuderski llvmlistbot at llvm.org
Fri Aug 2 08:36:12 PDT 2024


================
@@ -0,0 +1,61 @@
+//===- AttrToLLVMConverter.cpp - SPIR-V attributes conversion to LLVM -C++ ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include <mlir/Conversion/SPIRVCommon/AttrToLLVMConverter.h>
+
+namespace {
+using namespace mlir;
----------------
kuhar wrote:

nit: I you do:
```c++
namespace mlir {
namespace {
```

you won't have to reopen namespace `mlir` in the middle of the file later on

https://github.com/llvm/llvm-project/pull/101664


More information about the Mlir-commits mailing list