[Mlir-commits] [mlir] [mlir][vector] Update tests for xfer-flatten (nfc) (PR #101471)

Andrzej Warzyński llvmlistbot at llvm.org
Fri Aug 2 07:47:20 PDT 2024


banach-space wrote:

> > We may need to accept a tiny bit of inconsistency here ... 😅
> 
> Am I over doing it ? 

Not at all - you are being very thorough and that's greatly appreciated 🙏🏻 And in general, I suggest that you always trust your own judgement when reviewing. 

If there's something that I have limited bandwidth for I just try to be honest about it. It's then for the reviewer to decide how "critical" a particular request/suggestion is. Sometimes it's OK to leave things for later (e.g. a follow-up patch) or even ignore.

Thanks again for your help with this!

https://github.com/llvm/llvm-project/pull/101471


More information about the Mlir-commits mailing list