[Mlir-commits] [mlir] [MLIR][GPU-LLVM] Convert `gpu.func` to `llvm.func` (PR #101664)

Victor Perez llvmlistbot at llvm.org
Fri Aug 2 06:58:56 PDT 2024


victor-eds wrote:

> Thanks, Victor! This is really helpful, I was able to replace some dumb copy-pasted code locally :) Haven't tried the `llvm.ptr<3>` yet though. Would it require `gpu.launch` lowering changes?

Yeah, definitely. In fact, I've just figured out we're dropping information on the size of this memory allocations. `gpu.launch_func` won't know the required size of these memory attributions, so we would need to attach that information as an attribute to the lowered function. The rest of the PR is ready for review.

https://github.com/llvm/llvm-project/pull/101664


More information about the Mlir-commits mailing list