[Mlir-commits] [mlir] [MLIR][LLVM] Use CyclicReplacerCache for recursive DIType import (PR #98203)

[Tobias Gysi]

gysit wrote:

> can we do this without requiring all nodes to be cycle-breaking 🤔 (or is anything special with 0 that we can use to refine our rule).

What would be the implication in terms of implementation and performance if we make all nodes self recursive? I assume the implementation overheads could be hidden to some extend in a base class (but not entirely)?

I would probably go with the pragmatic solution (3.) and make `DISubprogram` cycle-breaking initially. I think it is fair to say that `DISubprogram` is special since it can is a scope and it has a type. I don't think this is the case for another scope attribute. But yes there may be other cyclic node types.

 

https://github.com/llvm/llvm-project/pull/98203