[Mlir-commits] [mlir] [mlir][emitc][cf] add 'cf.switch' support in CppEmitter (PR #101478)

Simon Camphausen llvmlistbot at llvm.org
Thu Aug 1 05:29:16 PDT 2024


https://github.com/simon-camp requested changes to this pull request.

Overall this looks good to me.

You should also add a case in [this check](https://github.com/llvm/llvm-project/blob/2feb0586b75bae87bb6e053b502ec7739da37837/mlir/lib/Target/Cpp/TranslateToCpp.cpp#L1000), otherwise you get a trailing semicolon after the switch body (I think, I haven't run the code).

https://github.com/llvm/llvm-project/pull/101478


More information about the Mlir-commits mailing list