[Mlir-commits] [mlir] [MLIR][LLVM] Attach kernel metadata representation to `llvm.func` (PR #101314)

Tobias Gysi llvmlistbot at llvm.org
Thu Aug 1 02:40:33 PDT 2024


================
@@ -226,6 +241,129 @@ static LogicalResult setNoaliasScopesAttr(const llvm::MDNode *node,
   return success();
 }
 
+/// Extract constant integer value from metadata if this is constant. Return
+/// `std::nullopt` otherwise.
----------------
gysit wrote:

```suggestion
/// Extracts an integer from the provided metadata `md` if possible. Returns nullopt otherwise.
```
nit: try to use back ticks for variable names only.

https://github.com/llvm/llvm-project/pull/101314


More information about the Mlir-commits mailing list