[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: Skip materializations when running without converter (PR #101318)

[Adrian Kuegel]

akuegel wrote:

I agree, this should not have been merged without a test. And by now I believe that in fact there is something wrong with the usage of DialectConversion in the case of the failures I looked at so far. It seems that recently a workaround was added to skip UnrealizedConversionCast operands in the conversion patterns. If I remove these workarounds, the tests pass. My guess is that https://github.com/llvm/llvm-project/pull/101148 was in fact fixing the issue that required the usage of the workarounds before.
I will prepare a rollback of this PR, and sorry for the trouble.

https://github.com/llvm/llvm-project/pull/101318