[Mlir-commits] [mlir] [mlir][MemRef] Add ExtractStridedMetadataOpCollapseShapeFolder (PR #89954)

Diego Caballero llvmlistbot at llvm.org
Thu Apr 25 13:57:34 PDT 2024


dcaballe wrote:

> I see two paths forward
> 
> 1. use `populateResolveExtractStridedMetadataPatterns` inside `populateExpandStridedMetadataPatterns` so that we can be sure `Resolve` is a subset of `Expand`. I think this is true today (modulo what [reviews.llvm.org/D147393](https://reviews.llvm.org/D147393) added, but re-converging remains good IMHO) and we can revisit when they need to diverge.
> 2. integrate a test in the narrowing type test pass, since this is the only place where `Resolve` is used.

Thanks for the suggesting. Ok, let me try 1.

https://github.com/llvm/llvm-project/pull/89954


More information about the Mlir-commits mailing list