[Mlir-commits] [mlir] [mlir][fold-memref-alias-ops] Add support for folding memref.expand_shape involving dynamic dims (PR #89093)

Prathamesh Tagore llvmlistbot at llvm.org
Thu Apr 25 12:25:44 PDT 2024


meshtag wrote:

> Since expand shape is now going to carry the shapes explicitly won't the logic here be much simpler?

I think that'll only change the way we get dynamic dimensions for analysis. Currently, we are getting them through the type (`memref.dim` over the resultant's type), but once that change gets in, we can get that information from the `output_shape` field. I don't expect it to change the logic however (we would still need to calculate the suffix product and then linearize those values to get the resultant map). 

If that PR has no blockers, I have no problem waiting for it to get in. 

https://github.com/llvm/llvm-project/pull/89093


More information about the Mlir-commits mailing list