[Mlir-commits] [mlir] [mlir][linalg] Enable fuse consumer (PR #89893)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed Apr 24 19:34:59 PDT 2024


MaheshRavishankar wrote:

Thanks @cxy-1993 for the change.  I have comments, but just want to state at the outset that these arent a reaction to this PR or the effort to follow through on recommendations, but just unfortunate evolution of things.

What is being done here is what I was trying to avoid. To test the interface methods now there is an implementation of tile and fuse in a test folder. I don't see how this is useful. 
https://github.com/llvm/llvm-project/pull/88712 is the place to test such a thing. This is why I didnt ask for tests on the original PR. So even if this is landed this way, all this is doing is adding more things to delete after the fact. I dont have the heart to block this change, but I really dont think this is a good outcome here.

https://github.com/llvm/llvm-project/pull/89893


More information about the Mlir-commits mailing list