[Mlir-commits] [mlir] [mlir-lsp] Log invalid notification params (PR #89856)

Brian Gesiak llvmlistbot at llvm.org
Wed Apr 24 09:28:59 PDT 2024


================
@@ -147,9 +147,14 @@ class MessageHandler {
                     void (ThisT::*handler)(const Param &)) {
     notificationHandlers[method] = [method, handler,
                                     thisPtr](llvm::json::Value rawParams) {
-      llvm::Expected<Param> param = parse<Param>(rawParams, method, "request");
----------------
modocache wrote:

I assume it was a typo, yeah. But the string would never be printed or logged anywhere prior to this change, so it didn't matter in practice :)

https://github.com/llvm/llvm-project/pull/89856


More information about the Mlir-commits mailing list