[Mlir-commits] [mlir] [mlir-lsp] Log invalid notification params (PR #89856)

Walter Erquinigo llvmlistbot at llvm.org
Wed Apr 24 09:20:14 PDT 2024


================
@@ -147,9 +147,14 @@ class MessageHandler {
                     void (ThisT::*handler)(const Param &)) {
     notificationHandlers[method] = [method, handler,
                                     thisPtr](llvm::json::Value rawParams) {
-      llvm::Expected<Param> param = parse<Param>(rawParams, method, "request");
----------------
walter-erquinigo wrote:

should this has been "notification" instead of "request" all along?

https://github.com/llvm/llvm-project/pull/89856


More information about the Mlir-commits mailing list