[Mlir-commits] [mlir] [mlir][ODS] Add namespace filtering to `-gen-enum-*` (PR #89627)
Mehdi Amini
llvmlistbot at llvm.org
Mon Apr 22 16:09:42 PDT 2024
joker-eph wrote:
> This is problematic if a dialect depends on another dialect and therefore transitively #includes another dialects enums: The declarations and definitions of the enum will be generated in both dialects and therefore lead to likely a compiler error and a guaranteed linker error.
It's not clear to me that this is actually a problem, isn't it is just a matter of organization of the .td files:
- `Dialect.td` : defines the dialect.
- `Enums.td`: include the dialect, defines the enums.
- `Ops.td`: uses the dialect and the enums.
https://github.com/llvm/llvm-project/pull/89627
More information about the Mlir-commits
mailing list