[Mlir-commits] [mlir] [mlir][linalg] Add runtime verification for linalg ops (PR #89342)
Matthias Springer
llvmlistbot at llvm.org
Mon Apr 22 10:27:28 PDT 2024
https://github.com/matthias-springer commented:
Looks like a nice improvement!
In case of static dimension sizes, does the (static) `LinalgOp` verifier have the same checks? Looks like we only verify the rank, but not dimension sizes (or maybe I missed it). In `Linalg/invalid.mlir`:
```
// expected-error @+1 {{op expected indexing_map #0 to have 1 dim(s) to match the number of loops}}
```
The runtime verifier and the op verifier should be in sync. Before we continue with this PR: If we're actually missing such static verification, could you add it in a separate PR and add @nicolasvasilache as one of the reviewers.
https://github.com/llvm/llvm-project/pull/89342
More information about the Mlir-commits
mailing list