[Mlir-commits] [mlir] [mlir][linalg] Enable fuse consumer (PR #85528)

[Stella Laurenzo]

stellaraccident wrote:

> > Definitely needs tests, but I didn't see a need for revert. Should be fine to add tests after the fact. @cxy-1993 and @Abhishek-Varma could we add some tests here
> 
> yeah, let's instead be consistent with what we've been doing so far: https://mlir.llvm.org/getting_started/TestingGuide/

Let's keep the bar high. Alex's suggestion is the right one: revert and land with appropriate tests.

> 
> Additionally, I believe this should also not have landed for the same reason as I am objecting to #88712 I'll just copy paste here:
> 
> Now, I am afraid I cannot subscribe to any large code changes to tiling transforms until #77874 is addressed to my satisfaction. I already gave a pass 6 months ago and another one 3 months ago when things were supposed to be addressed "in short order".
> 
> We're now past tech-debt reduction time: first let's address [mlir][TilingInterface] Use LoopLikeOpInterface in tiling using SCF to unify tiling with scf.for and scf.forall. #77874,

Can we get a f2f to talk about this separately? I've had my eye on this for a long time too, and there is a significant hairball that (believe it or not) is being undone. It is just hard and taking more iteration than expected.

https://github.com/llvm/llvm-project/pull/85528