[Mlir-commits] [flang] [mlir] [flang][OpenMP] Concatenate begin and end clauses into single list (PR #89090)

Sergio Afonso llvmlistbot at llvm.org
Mon Apr 22 04:49:21 PDT 2024


================
@@ -1091,16 +1091,12 @@ static void genParallelClauses(
 static void genSectionsClauses(Fortran::lower::AbstractConverter &converter,
                                Fortran::semantics::SemanticsContext &semaCtx,
                                const List<Clause> &clauses, mlir::Location loc,
-                               bool clausesFromBeginSections,
                                mlir::omp::SectionsClauseOps &clauseOps) {
   ClauseProcessor cp(converter, semaCtx, clauses);
-  if (clausesFromBeginSections) {
-    cp.processAllocate(clauseOps);
-    cp.processSectionsReduction(loc, clauseOps);
-    // TODO Support delayed privatization.
-  } else {
-    cp.processNowait(clauseOps);
-  }
+  cp.processAllocate(clauseOps);
+  cp.processSectionsReduction(loc, clauseOps);
+  // TODO Support delayed privatization.
+  cp.processNowait(clauseOps);
----------------
skatrak wrote:

Nit: Just to follow the existing convention, reorder `cp.process...` calls alphabetically and put the TODO comment at the end.

https://github.com/llvm/llvm-project/pull/89090


More information about the Mlir-commits mailing list