MaheshRavishankar wrote: Definitely needs tests, but I didn't see a need for revert. Should be fine to add tests after the fact. @cxy-1993 and @Abhishek-Varma could we add some tests here https://github.com/llvm/llvm-project/pull/85528