[Mlir-commits] [mlir] [mlir][MemRef] Extend `memref.subview` sub-byte type emulation support (PR #89488)

Ivan Butygin llvmlistbot at llvm.org
Sat Apr 20 02:49:29 PDT 2024


================
@@ -145,6 +145,10 @@ inline bool isReductionIterator(Attribute attr) {
 /// constant operations.
 SmallVector<int64_t> getAsIntegers(ArrayRef<Value> values);
 
+/// Returns the integer numbers in `foldResult`. `foldResult` is expected to
+/// be constant operations.
+int64_t getAsInteger(OpFoldResult foldResult);
----------------
Hardcode84 wrote:

Is this function needed? I can't see any usages in patch. Also, MLIR laredy has `getConstantIntValue` in `StaticValueUtils.h` let's not duplicate :)

https://github.com/llvm/llvm-project/pull/89488


More information about the Mlir-commits mailing list