[Mlir-commits] [mlir] [MLIR][SCF] Add an API to fuse consumer to a producer within scf loop (PR #88712)

Abhishek Varma llvmlistbot at llvm.org
Fri Apr 19 04:37:58 PDT 2024


Abhishek-Varma wrote:

Thank you @MaheshRavishankar @ftynse for your review comments! The one involving `OpOperand &` was extremely helpful and made the code super clean! Thank you.

I've addressed all your comments except the ones related to `TilingInterface.td` and `TilingInterfaceImpl.cpp` - since it is based of the [in-flight PR 88528](https://github.com/llvm/llvm-project/pull/85528) that will add these.
Perhaps it's best handled there?

The major changes in the latest push in this PR are :-
1. Add ability to deal with consumer yielding multiple values - previously I was constraining it to be a single yielding consumer.
2. I have updated all the assumptions with necessary checks and returning `failure()` in case it fails.
3. The newer algo mentioned [here](https://github.com/llvm/llvm-project/pull/88712#discussion_r1571929731).

https://github.com/llvm/llvm-project/pull/88712


More information about the Mlir-commits mailing list