[Mlir-commits] [mlir] [mlir][linalg] Add pass to transpose matmul op (PR #89075)

Cullen Rhodes llvmlistbot at llvm.org
Fri Apr 19 00:08:01 PDT 2024


c-rhodes wrote:

> I don't see any major concerns... We have `linalg.matmul` and `linalg.matmul_transpose_a/b` operations so having patterns to go from one another seem something basic to have (we may also want to add the `batch` variants).
> 
> Having a simple pass to exercise them should also be ok as long as we set the expectations properly (i.e., this is expected to be a simple matmul transposition and not going into specific target-dependent tuning, complex data layout transformations, etc.)

Thanks for reviewing. I'll add a comment to the pass the set expectations 👍 

https://github.com/llvm/llvm-project/pull/89075


More information about the Mlir-commits mailing list