[Mlir-commits] [mlir] Let `memref.{expand, collapse}_shape` implement `ReifyRankedShapedTypeOpInterface` (PR #89111)

Benoit Jacob llvmlistbot at llvm.org
Thu Apr 18 08:13:17 PDT 2024


bjacob wrote:

Thanks for the drive-by review. Actually I am rebasing on top of https://github.com/llvm/llvm-project/pull/69267 , which will make this PR trivial as now the output shape is encoded on the op already. The code simplifies to

```c++
LogicalResult ExpandShapeOp::reifyResultShapes(
    OpBuilder &builder, ReifiedRankedShapedTypeDims &reifiedResultShapes) {
  reifiedResultShapes = {
      getMixedValues(getStaticOutputShape(), getOutputShape(), builder)};
  return success();
}
```

https://github.com/llvm/llvm-project/pull/89111


More information about the Mlir-commits mailing list