[Mlir-commits] [mlir] 3f0d52b - [mlir][llvm] Clean out f8 types from compatible types list

[Benjamin Kramer]

Author: Benjamin Kramer
Date: 2024-04-18T13:50:19+02:00
New Revision: 3f0d52b2dbdb096212e8ffa6ad86aacd0d256957

URL: https://github.com/llvm/llvm-project/commit/3f0d52b2dbdb096212e8ffa6ad86aacd0d256957
DIFF: https://github.com/llvm/llvm-project/commit/3f0d52b2dbdb096212e8ffa6ad86aacd0d256957.diff

LOG: [mlir][llvm] Clean out f8 types from compatible types list

These were added in faf697e49bad099b36770c7738f36917e3d90d2d so things
can flow through non-opaque LLVM ptrs. Those ptrs are gone so there is
no reason for this to be around anymore. LLVM doesn't support f8 types,
they get converted to i8 when lowering to LLVM dialect.

Removing the f8 types makes LLVM::isCompatibleType and
LLVM::isCompatibleFloatingPointType consistent again.

Added: 
    

Modified: 
    mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp
index 630187f220a4ba..ad1dc4a36b82b8 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp
@@ -769,8 +769,6 @@ bool mlir::LLVM::isCompatibleOuterType(Type type) {
       Float64Type,
       Float80Type,
       Float128Type,
-      Float8E4M3FNType,
-      Float8E5M2Type,
       LLVMArrayType,
       LLVMFunctionType,
       LLVMLabelType,
@@ -841,8 +839,6 @@ static bool isCompatibleImpl(Type type, DenseSet<Type> &compatibleTypes) {
             Float64Type,
             Float80Type,
             Float128Type,
-            Float8E4M3FNType,
-            Float8E5M2Type,
             LLVMLabelType,
             LLVMMetadataType,
             LLVMPPCFP128Type,