[Mlir-commits] [mlir] [mlir][ArmNeon] Update `LowerContractionToSMMLAPattern` to support proper unrolling for k dimension (PR #88591)
Andrzej WarzyĆski
llvmlistbot at llvm.org
Tue Apr 16 08:15:39 PDT 2024
https://github.com/banach-space commented:
I'm not super familiar with this pattern, but this change makes sense to me, thanks for working on this!
How about unrolling along the K _and_ some other dim? Could you add a test? That doesn't have to capture all the generated ops - just the relationship between `smmla` Ops (to demonstrate that the accumulator is only re-used where it makes sense).
https://github.com/llvm/llvm-project/pull/88591
More information about the Mlir-commits
mailing list