[Mlir-commits] [mlir] [mlir][OpenMP] add missing load for reduction cleanup region (PR #88289)

Kiran Chandramohan llvmlistbot at llvm.org
Wed Apr 10 09:27:00 PDT 2024


================
@@ -889,8 +889,17 @@ static LogicalResult inlineReductionCleanup(
 
     // map the argument to the cleanup region
     Block &entry = cleanupRegion.front();
-    moduleTranslation.mapValue(entry.getArgument(0),
-                               privateReductionVariables[i]);
+
+    llvm::Instruction *potentialTerminator =
+        builder.GetInsertBlock()->empty() ? nullptr
+                                          : &builder.GetInsertBlock()->back();
----------------
kiranchandramohan wrote:

What is the case where there is no terminator?

https://github.com/llvm/llvm-project/pull/88289


More information about the Mlir-commits mailing list