[Mlir-commits] [mlir] [mlir] remove folder on MemRef::ExtractStridedMetadataOp (PR #88043)

[Mehdi Amini]

joker-eph wrote:

ExtractStridedMetadataOp Is really an abstraction breaking op, so it’s hard to me to argue about “correctness”: it reminds me of these ops in the bufferization dialect that only exist within specific invariant of the bufferization process.

It would be great if we could start with the documentation of this op, and carefully describe its invariant and intended usage first: at the moment, when rereading https://mlir.llvm.org/docs/Dialects/MemRef/#memrefextract_strided_metadata-memrefextractstridedmetadataop it seems like this op exists to expose separately thing like pointer and offset and to enable folding!
Let make sure the doc is very clear and then look into what kind of folding reasonably matches the intent for this op.

https://github.com/llvm/llvm-project/pull/88043