[Mlir-commits] [mlir] [MLIR] Don't check for key before inserting in map in GreedyPatternRewriteDriver worklist (NFC) (PR #88148)

Stella Laurenzo llvmlistbot at llvm.org
Tue Apr 9 10:05:28 PDT 2024


https://github.com/stellaraccident approved this pull request.

Wow! A clang tidy check would indeed be good. I've written the correct form thousands of times and (almost) always go out of my way to do it, but I often have to hit the docs to remember exactly which form of insert/second does what I want. It's not surprising to me that people can't remember this and just write the simpler to understand form thinking it won't hurt too much.

https://github.com/llvm/llvm-project/pull/88148


More information about the Mlir-commits mailing list