[Mlir-commits] [mlir] 0e5a53c - [MLIR] Fix typo bug in AffineExprVisitor for WalkResult return case (#86138)

[llvmlistbot at llvm.org]

Author: Uday Bondhugula
Date: 2024-04-09T08:37:57+05:30
New Revision: 0e5a53cc01e406436cb7c703c84598e474d635de

URL: https://github.com/llvm/llvm-project/commit/0e5a53cc01e406436cb7c703c84598e474d635de
DIFF: https://github.com/llvm/llvm-project/commit/0e5a53cc01e406436cb7c703c84598e474d635de.diff

LOG: [MLIR] Fix typo bug in AffineExprVisitor for WalkResult return case (#86138)

Fix typo bug in AffineExprVisitor for the WalkResult return case. This
didn't show up immmediately because most walks in the tree didn't
use walk result.

Added: 
    

Modified: 
    mlir/include/mlir/IR/AffineExprVisitor.h
    mlir/test/IR/affine-walk.mlir

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/IR/AffineExprVisitor.h b/mlir/include/mlir/IR/AffineExprVisitor.h
index 3e1bbb4b3fa0ea..27c49cd80018e9 100644
--- a/mlir/include/mlir/IR/AffineExprVisitor.h
+++ b/mlir/include/mlir/IR/AffineExprVisitor.h
@@ -222,7 +222,7 @@ class AffineExprVisitor : public AffineExprVisitorBase<SubClass, RetTy> {
       walkPostOrder(expr.getLHS());
     }
     if constexpr (std::is_same<RetTy, WalkResult>::value) {
-      if (walkPostOrder(expr.getLHS()).wasInterrupted())
+      if (walkPostOrder(expr.getRHS()).wasInterrupted())
         return WalkResult::interrupt();
       return WalkResult::advance();
     } else {

diff  --git a/mlir/test/IR/affine-walk.mlir b/mlir/test/IR/affine-walk.mlir
index 1de675ac70be2d..0ee7abf9415cf3 100644
--- a/mlir/test/IR/affine-walk.mlir
+++ b/mlir/test/IR/affine-walk.mlir
@@ -7,3 +7,8 @@
 
 "test.check_first_mod"() {"map" = #map} : () -> ()
 // expected-remark at -1 {{mod expression}}
+
+#map_rhs_mod = affine_map<(i, j) -> (i + i mod 2, j)>
+
+"test.check_first_mod"() {"map" = #map_rhs_mod} : () -> ()
+// expected-remark at -1 {{mod expression}}