[Mlir-commits] [mlir] [mlir] remove folder on MemRef::ExtractStridedMetadataOp (PR #88043)

Nirvedh Meshram llvmlistbot at llvm.org
Mon Apr 8 17:38:49 PDT 2024


================
@@ -870,38 +870,6 @@ func.func @reinterpret_of_subview(%arg : memref<?xi8>, %size1: index, %size2: in
 
 // -----
 
-// Check that a reinterpret cast of an equivalent extract strided metadata
----------------
nirvedhmeshram wrote:

These two tests are testing  a canonicalization feature of `reinterpret_cast` which wouldnt be triggered without the folder of `extract_strided_metadata` so input/output IR are exactly same so I didnt see much value in the test. Should I add it back as is, or should I change it so that the actual interpret cast canonicalization is tested?

https://github.com/llvm/llvm-project/pull/88043


More information about the Mlir-commits mailing list