[Mlir-commits] [mlir] 40327a6 - Revert "[mlir][arith] Refine the verifier for arith.constant (#86178)"

[Andrzej Warzynski]

Author: Andrzej Warzynski
Date: 2024-04-08T14:39:20+01:00
New Revision: 40327a628ace90870c7caa0db448a0f2d9863df0

URL: https://github.com/llvm/llvm-project/commit/40327a628ace90870c7caa0db448a0f2d9863df0
DIFF: https://github.com/llvm/llvm-project/commit/40327a628ace90870c7caa0db448a0f2d9863df0.diff

LOG: Revert "[mlir][arith] Refine the verifier for arith.constant (#86178)"

This reverts commit 662c62609e8ee2dc996da69e11c0d594e799c299.

Broken both:
  * https://lab.llvm.org/buildbot/#/builders/61/builds/56565

Added: 
    

Modified: 
    mlir/lib/Dialect/Arith/IR/ArithOps.cpp
    mlir/test/Dialect/Arith/invalid.mlir

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/Arith/IR/ArithOps.cpp b/mlir/lib/Dialect/Arith/IR/ArithOps.cpp
index efc4bfe622d53a..1d68a4f7292b53 100644
--- a/mlir/lib/Dialect/Arith/IR/ArithOps.cpp
+++ b/mlir/lib/Dialect/Arith/IR/ArithOps.cpp
@@ -213,12 +213,6 @@ LogicalResult arith::ConstantOp::verify() {
     return emitOpError(
         "value must be an integer, float, or elements attribute");
   }
-
-  auto vecType = dyn_cast<VectorType>(type);
-  if (vecType && vecType.isScalable() && !isa<SplatElementsAttr>(getValue()))
-    return emitOpError(
-        "intializing scalable vectors with elements attribute is not supported"
-        " unless it's a vector splat");
   return success();
 }
 

diff  --git a/mlir/test/Dialect/Arith/invalid.mlir b/mlir/test/Dialect/Arith/invalid.mlir
index fdc907a7c6af13..6d8ac0ada52be3 100644
--- a/mlir/test/Dialect/Arith/invalid.mlir
+++ b/mlir/test/Dialect/Arith/invalid.mlir
@@ -64,15 +64,6 @@ func.func @constant_out_of_range() {
 
 // -----
 
-func.func @constant_invalid_scalable_vec_initialization() {
-^bb0:
-  // expected-error at +1 {{'arith.constant' op intializing scalable vectors with elements attribute is not supported unless it's a vector splat}}
-  %c = arith.constant dense<[0, 1]> : vector<[2] x i32>
-  return
-}
-
-// -----
-
 func.func @constant_wrong_type() {
 ^bb:
   %x = "arith.constant"(){value = 10.} : () -> f32 // expected-error {{'arith.constant' op failed to verify that all of {value, result} have same type}}