[Mlir-commits] [flang] [mlir] [MLIR][LLVM] Add DebugNameTableKind to DICompileUnit (PR #87974)

Tobias Gysi llvmlistbot at llvm.org
Mon Apr 8 04:38:22 PDT 2024


================
@@ -56,10 +56,14 @@ DIBasicTypeAttr DebugImporter::translateImpl(llvm::DIBasicType *node) {
 DICompileUnitAttr DebugImporter::translateImpl(llvm::DICompileUnit *node) {
   std::optional<DIEmissionKind> emissionKind =
       symbolizeDIEmissionKind(node->getEmissionKind());
+  std::optional<DINameTableKind> nameTableKind = symbolizeDINameTableKind(
+      static_cast<
+          std::underlying_type_t<llvm::DICompileUnit::DebugNameTableKind>>(
----------------
gysit wrote:

Is this necessary? For DIEmissionKind we seem to use the enum directly without static cast? Or should both use a cast to the underlying type in both cases?

https://github.com/llvm/llvm-project/pull/87974


More information about the Mlir-commits mailing list