[Mlir-commits] [mlir] 269d0aa - [mlir] Apply ClangTidy findings.
Adrian Kuegel
llvmlistbot at llvm.org
Wed Apr 3 07:14:31 PDT 2024
Author: Adrian Kuegel
Date: 2024-04-03T14:14:06Z
New Revision: 269d0aaec1801000a39122b1c5792d9c096b33ec
URL: https://github.com/llvm/llvm-project/commit/269d0aaec1801000a39122b1c5792d9c096b33ec
DIFF: https://github.com/llvm/llvm-project/commit/269d0aaec1801000a39122b1c5792d9c096b33ec.diff
LOG: [mlir] Apply ClangTidy findings.
modernize-use-override ClangTidy check.
This warning appears on overridden virtual functions not marked with override or
final keywords or marked with more than one of virtual, override, final.
Added:
Modified:
mlir/include/mlir/Pass/Pass.h
Removed:
################################################################################
diff --git a/mlir/include/mlir/Pass/Pass.h b/mlir/include/mlir/Pass/Pass.h
index 0f50f3064f1780..e71c49a1687fed 100644
--- a/mlir/include/mlir/Pass/Pass.h
+++ b/mlir/include/mlir/Pass/Pass.h
@@ -355,7 +355,7 @@ class Pass {
template <typename OpT = void>
class OperationPass : public Pass {
public:
- ~OperationPass() = default;
+ ~OperationPass() override = default;
protected:
OperationPass(TypeID passID) : Pass(passID, OpT::getOperationName()) {}
@@ -400,7 +400,7 @@ class OperationPass : public Pass {
template <>
class OperationPass<void> : public Pass {
public:
- ~OperationPass() = default;
+ ~OperationPass() override = default;
protected:
OperationPass(TypeID passID) : Pass(passID) {}
@@ -461,7 +461,7 @@ class PassWrapper : public BaseT {
static bool classof(const Pass *pass) {
return pass->getTypeID() == TypeID::get<PassT>();
}
- ~PassWrapper() = default;
+ ~PassWrapper() override = default;
protected:
PassWrapper() : BaseT(TypeID::get<PassT>()) {}
More information about the Mlir-commits
mailing list