[Mlir-commits] [mlir] [OpenMP][Flang] Add "IsolatedFromAbove" and "OutlineableOpenMPOpInterface" trait to omp.target (PR #67164)

[Akash Banerjee]

================
@@ -693,6 +693,12 @@ static ParseResult parseMapClause(OpAsmParser &parser, IntegerAttr &mapType) {
     if (mapTypeMod == "always")
       mapTypeBits |= llvm::omp::OpenMPOffloadMappingFlags::OMP_MAP_ALWAYS;
 
+    if (mapTypeMod == "literal")
+      mapTypeBits |= llvm::omp::OpenMPOffloadMappingFlags::OMP_MAP_LITERAL;
+
+    if (mapTypeMod == "implicit")
+      mapTypeBits |= llvm::omp::OpenMPOffloadMappingFlags::OMP_MAP_IMPLICIT;
----------------
TIFitis wrote:

Sorry, I missed adding this change to the summary. I've now updated it.

The implicit attribute has been removed from the MapInfoOp as the implicit information is already captured by the implicit map_type flag. As such, I've removed that attribute and instead updated the custom printer and parser for the map_types to also show the `implicit` and `literal` flags.

The `implicit` flag is definitely needed as otherwise that information would be lost. I'll look into whether it is okay to set the `literal` flag at a later stage during MLIR translation.

https://github.com/llvm/llvm-project/pull/67164