[Mlir-commits] [mlir] [OpenMP][Flang] Add "IsolatedFromAbove" and "OutlineableOpenMPOpInterface" trait to omp.target (PR #67164)

[Kiran Chandramohan]

kiranchandramohan wrote:

> I think there should be both map and block arguments, former to make lowering easier and carry map information for the captures, whilst making the mapping more explicit to readers of the IR and the latter to fulfil the IsolatedFromAbove interface, I think this patch does that currently. Perhaps sometime in the future the BlockArgs and Map clauses can be aligned so we only have one, not too sure how you'd go about doing that though, perhaps make an extended BlockArgs operation(?) for Map or a map clause interface for BlockArgs.

Not clear whether you are suggesting changes for this patch or explaining what is being done here.
Wouldn't the ones that are block arguments be subject to implicit data-mapping rules (https://www.openmp.org/spec-html/5.2/openmpsu60.html)? Would it be better to make all of the block arguments and use an attribute in the `MapInfo` operation to distinguish the implicit ones?

https://github.com/llvm/llvm-project/pull/67164