[Mlir-commits] [mlir] [OpenMP][Flang] Add "IsolatedFromAbove" and "OutlineableOpenMPOpInterface" trait to omp.target (PR #67164)

[Kiran Chandramohan]

kiranchandramohan wrote:

> > The `OutlineableOpenMPOpInterface` looks like a separate change.
> 
> Other operations inside the target region such as WS loop may try to add new allocas outside the target region. Because of the `IsolatedFromAbove` trait, this should not be allowed. To prevent other operations from adding such allocas, the `OutlineableOpenMPOpInterface` trait is also added in conjunction. With this trait new allocas from other operations are added inside the target region.

Without the `IsolatedFromAbove` trait as well I think the target region should have the `OutlineableOpenMPOpInterface` since the `alloca` should be on a target device and not hoisted up to a host allocation. Also, the target region is outlined as well.

https://github.com/llvm/llvm-project/pull/67164