[Mlir-commits] [mlir] 2ff45f0 - Don't use LLVM_TABLEGEN_FLAGS with mlir-pdll: it's not a TableGen tool (#67486)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Sep 26 14:38:48 PDT 2023


Author: Mehdi Amini
Date: 2023-09-26T14:38:44-07:00
New Revision: 2ff45f04a6d32b20558f07d1017e861b48317592

URL: https://github.com/llvm/llvm-project/commit/2ff45f04a6d32b20558f07d1017e861b48317592
DIFF: https://github.com/llvm/llvm-project/commit/2ff45f04a6d32b20558f07d1017e861b48317592.diff

LOG: Don't use LLVM_TABLEGEN_FLAGS with mlir-pdll: it's not a TableGen tool (#67486)

This can lead to build failure when a project is customizing this flag
for TableGen. This seems to have been copy/pasted from TableGen CMake
functions.

Added: 
    

Modified: 
    mlir/cmake/modules/AddMLIR.cmake

Removed: 
    


################################################################################
diff  --git a/mlir/cmake/modules/AddMLIR.cmake b/mlir/cmake/modules/AddMLIR.cmake
index 6acb01c305ad025..4622d4d05fcbdeb 100644
--- a/mlir/cmake/modules/AddMLIR.cmake
+++ b/mlir/cmake/modules/AddMLIR.cmake
@@ -108,7 +108,6 @@ function(_pdll_tablegen project ofn)
   add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${ofn}
     COMMAND ${tablegen_exe} ${ARG_UNPARSED_ARGUMENTS} -I ${CMAKE_CURRENT_SOURCE_DIR}
     ${tblgen_includes}
-    ${LLVM_TABLEGEN_FLAGS}
     ${LLVM_TARGET_DEFINITIONS_ABSOLUTE}
     ${tblgen_change_flag}
     ${additional_cmdline}


        


More information about the Mlir-commits mailing list